Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with keyboardShouldPersistTaps. #127

Open
luco opened this issue Sep 18, 2017 · 13 comments
Open

Not working with keyboardShouldPersistTaps. #127

luco opened this issue Sep 18, 2017 · 13 comments
Labels

Comments

@luco
Copy link

luco commented Sep 18, 2017

Thank you for this plugin. It's really nice.
I caught a bug while doing some tests. It seems that it doesn't respond to a ScrollView with keyboardShouldPersistTaps='never' while a TextInput does.

Any thoughts?

Thanks

@iRoachie
Copy link
Collaborator

Hey there @luco, could you create a simple repo that would replicate this behavior or paste your example here?

@ansal-exp
Copy link

I have created one in the snack. https://snack.expo.io/rJ7NGqQmG please check. It seems so weird.
Its actually dismissing the keyboard but takes a second to dismiss the keyboard.

@iRoachie
Copy link
Collaborator

iRoachie commented Jan 7, 2018

Alright @ansal-exp, I confirmed that keyboardShouldPersistTaps="never" doesn't work. Any material you can point me to to get this fixed would be grateful

@iRoachie iRoachie added bug and removed help wanted labels Jan 7, 2018
@ansal-exp
Copy link

I think its a bug with react-native bundled scrollview, so it should be first reported on react-native github.

@iRoachie
Copy link
Collaborator

iRoachie commented Jan 8, 2018

It's probably not a bug per say, it may just be that their TextInput component handles this under the hood

@ansal-exp
Copy link

But, the thing is, keyboard is always be connected to a textinput. And the scrollview prop keyboardShouldPersistTaps is used to give us handling of the keyboard appearance. If the textinput is intended to handle the things solely, there is no need of any such props.

@toinfinityandbeyond
Copy link

Same issue over here.
Search bar remains focused no matter where I tap...Even with keyboardShouldPersistTaps='never' and keyboardDismissMode: 'on-drag'

Did you find any solution?

@iRoachie
Copy link
Collaborator

Haven't found a solution as yet @toinfinityandbeyond, still looking into how I can implement

@iRoachie
Copy link
Collaborator

@umhan35 Can you shed some light?

@umhan35
Copy link
Owner

umhan35 commented Feb 1, 2018

I remember somehow I had a similar issue. I'll take a look at my code and get back to you this week.

@toinfinityandbeyond
Copy link

Any update @umhan35 ?

@RodolfoGS
Copy link

Any update about this? I have the same issue

@FrankFundel
Copy link

FrankFundel commented Jan 10, 2021

+1

UPDATE: Using keyboardDismissMode="on-drag" works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants