Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent email login and subscription behaviour #1573

Open
paskal opened this issue Jan 8, 2023 · 1 comment
Open

Inconsistent email login and subscription behaviour #1573

paskal opened this issue Jan 8, 2023 · 1 comment
Assignees
Labels

Comments

@paskal
Copy link
Collaborator

paskal commented Jan 8, 2023

Logging in with email requires the user to click the Submit button:
image

However, posting the token into the email subscription form posts it automatically without pushing any buttons:
image

I propose to make the behaviour consistent and make email login submit the form once the token is parsed, the same as the subscription form behaves at the moment.

@akellbl4
Copy link
Collaborator

akellbl4 commented Nov 8, 2024

This comment relates to this issue.
As I mentioned there, all drop downs should use the same code for consistency.

The thing with tokens is we don't want to close the dropdown if we accidentally click outside of it because it can create confusion. For other cases it's fine to close dropdown with click outside because you won't loose any progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants