Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Icons blurry on HiDPI #67

Open
peteruithoven opened this issue Jan 30, 2019 · 4 comments
Open

Icons blurry on HiDPI #67

peteruithoven opened this issue Jan 30, 2019 · 4 comments

Comments

@peteruithoven
Copy link
Contributor

I noticed that the icons's are a bit blurry. Could be caused by my HiDPI screen?
For comparison screenshot with icon on snapcraft site on the left:
screenshot from 2019-01-30 15 51 49
screenshot from 2019-01-30 15 50 25

List:
screenshot from 2019-01-23 14 51 16

Tested with latest master, 1.0.0 tagged version.

@peteruithoven
Copy link
Contributor Author

It might not be Snaptastics fault though, the Snap icon is also blurry in the Applications menu:
screenshot from 2019-01-30 15 58 58 2x

@unbelievableflavour
Copy link
Owner

unbelievableflavour commented Jan 30, 2019 via email

@peteruithoven
Copy link
Contributor Author

peteruithoven commented Jan 30, 2019

as the size of the AsyncImage

Which one?

Application menu doesn't seem to include any icon scale factor correction logic::
https://github.com/elementary/applications-menu/blob/master/src/Widgets/AppEntry.vala#L70
https://github.com/elementary/applications-menu/blob/master/src/Widgets/AppEntry.vala#L105

AsyncImage automatically seems to correct for the scale factor:
https://github.com/elementary/granite/blob/master/lib/Widgets/AsyncImage.vala

@unbelievableflavour
Copy link
Owner

In this function https://github.com/bartzaalberg/snaptastic/blob/master/src/IconHandler.vala#L47 I get the Icon from file. Most of the time 64x64 is the result there. If not it will fallback to 48x48 and so on. In the same file you have the var 'icon_size' which is 32. This variable is used in the AsyncImage for the lists. In https://github.com/bartzaalberg/snaptastic/blob/master/src/Components/DetailViewBanner.vala you find the icon for the detailview. In the reload_view function in that file it is set to icon_size 64x64 for the asyncImage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants