Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid HTML: <h1> Nested Inside <span> #968

Open
PavelPancocha opened this issue Jan 15, 2025 · 1 comment
Open

fix: invalid HTML: <h1> Nested Inside <span> #968

PavelPancocha opened this issue Jan 15, 2025 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@PavelPancocha
Copy link
Contributor

What version of Unfold are you using?

0.44.0

What version of Django are you using?

4.2

What browser are you using?

Not browser related

Did you check changelog/commit history, if the bug is not already fixed?

Yes ✅

Did you search for other issues, if the bug is not already fixed?

Yes ✅

Are you able to replicate the bug in the demo site?

Yes:
image

Describe your issue

When using the HTML validator, we get an error that <h1> tag should not be part of <span> element.

Suggestion: Get rid of the h1 tag and style site name to look the same
@lukasvinclav lukasvinclav changed the title Invalid HTML: <h1> Nested Inside <span> fix: iInvalid HTML: <h1> Nested Inside <span> Jan 15, 2025
@lukasvinclav lukasvinclav changed the title fix: iInvalid HTML: <h1> Nested Inside <span> fix: invalid HTML: <h1> Nested Inside <span> Jan 15, 2025
@lukasvinclav lukasvinclav added bug Something isn't working good first issue Good for newcomers labels Jan 15, 2025
@PavelPancocha
Copy link
Contributor Author

@lukasvinclav: do you have a preferred way to fix this?

@PavelPancocha PavelPancocha mentioned this issue Jan 23, 2025
Open
Yuliaborzhak added a commit to Yuliaborzhak/django-unfold that referenced this issue Jan 23, 2025
@Yuliaborzhak
fix: invalid HTML: <h1> Nested Inside <span> (unfoldadmin#968)
07f0f60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukasvinclav @PavelPancocha