Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buttons doesn't fit in one row then there are too many items in actions_row #976

Open
danfimov opened this issue Jan 16, 2025 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@danfimov
Copy link

What version of Unfold are you using?

0.42.0

What version of Django are you using?

4.2.17

What browser are you using?

Arc browser - Version 1.77.0 (57419)

Did you checked changelog/commit history, if the bug is not already fixed?

Yes

Did you searched other issues, if the bug is not already fixed?

Yes

Did you checked documentation?

Yes

Are you able to replicate the bug in the demo site?

No

Repository with reproduced bug

Don't have open one, sorry

Describe your issue

I have model with many elements in actions_row. When buttons for them are rendered in one row, there are not enough space for all of them:

Image

I think putting them in two rows in such cases or creating a dropdown menu instead of list of buttons would be a possible solution.

Link on discussion about that issue in Discord

@lukasvinclav lukasvinclav added bug Something isn't working good first issue Good for newcomers labels Jan 16, 2025
@lukasvinclav lukasvinclav changed the title Buttons doesn't fit in one row then there are too many items in actions_row fix: buttons doesn't fit in one row then there are too many items in actions_row Jan 16, 2025
@mdimado
Copy link

mdimado commented Jan 17, 2025

I can try working on this. please assign.

@mdimado
Copy link

mdimado commented Jan 17, 2025

I would like to know the exact codefile for this issue as i am new to the codebase

@Zerotask
Copy link
Contributor

@mdimado

I would like to know the exact codefile for this issue as i am new to the codebase

Just a quick hint, how you can identify the proper file:
use the search above and search for actions_row as this was mentioned above. Search only in this repository:

Image

Then you will get these results:
https://github.com/search?q=repo%3Aunfoldadmin%2Fdjango-unfold%20actions_row&type=code

Then at the bottom, you can find:

Image

and here you have the file:
https://github.com/unfoldadmin/django-unfold/blob/b9ea7df877af80da01de96aeccf250d802fdc56e/src/unfold/templates/unfold/helpers/actions_row.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants