CLDR-14925 Preliminary clean-up for snapshot of Priority Items Summary (#1646)

-Call System.out.println, not System.err.println, unless it is an error

-Make some debugging output conditional on DEBUG or DEBUG_THREADS

-Move an URL to CLDRURLS.PRIORITY_SUMMARY_HELP_URL

-Call ph.shouldHide slightly sooner to avoid wasting time

-Move some code into a new subroutine recordEnglishChanged

-Fix deprecation warning for SurveyLog.logException

-Employ existing method getChoiceSetForOrg instead of duplicating code

-Remove dead code

-Make private where possible

-Formatting

-Comments

Author: btangmu

tools/cldr-apps/src/main/java/org/unicode/cldr/web/ReviewHide.java

@@ -41,7 +41,13 @@ public static void createTable(Connection conn) throws SQLException {
         }
     }
 
-    //get all the field for an user and locale
+    /**
+     * Get a map of all the notifications this user has chosen to hide in the Dashboard
+     *
+     * @param userId
+     * @param locale
+     * @return the map
+     */
     public HashMap<String, List<String>> getHiddenField(int userId, String locale) {
         if (this.hiddenField.isEmpty()) {
             Connection conn = null;
@@ -57,8 +63,9 @@ public HashMap<String, List<String>> getHiddenField(int userId, String locale) {
                     while (rs.next()) {
                         String choice = rs.getString("choice");
                         List<String> paths = this.hiddenField.get(choice);
-                        if (paths == null)
+                        if (paths == null) {
                             paths = new ArrayList<>();
+                        }
                         paths.add(rs.getString("path"));
 
                         this.hiddenField.put(choice, paths);