merging

Author: sven-oly

.github/workflows/clang-tidy-review.yml

@@ -0,0 +1,31 @@
+name: Run C++ Tests
+
+on:
+  push:
+    branches:
+      - main
+      - 'maint/maint*'
+  pull_request:
+    branches: '**'
+
+jobs:
+  build:
+    name: Lint ICU4C C++ executor
+    runs-on: ubuntu-latest
+
+    permissions:
+      contents: read  # change to write for thread comments
+      # metadata: read # for thread comments
+      # pull-requests: write # for pull request reviews
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Setup deps, etc. # install JSON-C, download ICU4C binaries if not present
+      run: |
+        bash setup.sh
+        sudo apt-get install libicu-dev
+    - name: Run clang-tidy
+      run: |
+        pushd executors/cpp
+        clang-tidy  *.cpp --config-file="clang-tidy-config.yml" -p .

.github/workflows/dart.yaml

@@ -0,0 +1,53 @@
+name: package:dart_executor
+permissions: read-all
+
+on:
+  pull_request:
+    branches: [main]
+    paths:
+      - ".github/workflows/dart.yaml"
+      - "executors/dart**"
+  push:
+    branches: [main]
+    paths:
+      - ".github/workflows/dart.yaml"
+      - "executors/dart**"
+  schedule:
+    - cron: "0 0 * * 0" # weekly
+
+jobs:
+  build_and_test:
+    runs-on: ${{ matrix.os }}
+
+    defaults:
+      run:
+        working-directory: executors/dart
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+    steps:
+      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+
+      - uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
+        with:
+          sdk: 3.10.0-37.0.dev
+
+      - run: dart pub get
+
+      - name: Check formatting
+        run: dart format --output=none --set-exit-if-changed .
+        if: always()
+
+      - name: Analyze code
+        run: dart analyze --fatal-infos
+        if: always()
+
+      - run: dart test
+
+      - run: dart test -p chrome
+
+      - name: Check if version is set correctly
+        run: |
+          dart bin/set_version.dart
+          dart bin/make_runnable_by_node.dart
+          git diff --exit-code

.github/workflows/e2e.yml

@@ -16,7 +16,7 @@ permissions:
 
 jobs:
   run_all:
-    name: End-to-end (Gen data, run tests, gen GH Pages)
+    name: End-to-end
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repo
@@ -33,18 +33,18 @@ jobs:
       - name: Setup version of Dart
         uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
         with:
-          sdk: dev
+          sdk: 3.10.0-37.0.dev
       - name: Set version of Rust
         uses: actions-rs/toolchain@v1
         with:
-            toolchain: 1.73
+            toolchain: 1.82
       - name: Run End-to-end script
         run: bash generateDataAndRun.sh
       - name: Setup Pages
         id: pages
-        uses: actions/configure-pages@v3
+        uses: actions/configure-pages@v4
       - name: Upload artifact
-        uses: actions/upload-pages-artifact@v1
+        uses: actions/upload-pages-artifact@v3
         with:
           path: TEMP_DATA/testReports/
 
@@ -53,10 +53,14 @@ jobs:
     if: ${{ github.event_name == 'push' && github.ref_name == 'main' }}
     runs-on: ubuntu-latest
     needs: run_all
+    # Grant GITHUB_TOKEN the permissions required to make a Pages deployment
+    permissions:
+      pages: write      # to deploy to Pages
+      id-token: write   # to verify the deployment originates from an appropriate source
     environment:
       name: github-pages
       url: ${{ steps.deployment.outputs.page_url }}
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v1
+        uses: actions/deploy-pages@v4

.github/workflows/run-rust.yml

@@ -11,14 +11,14 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        icu4x-version: [ '1.3', '1.4' ]
-    name: Lint the executor code for ICU4X
+        icu4x-version: [ '1.3', '1.4', '1.5', '2.0-beta1', '2.0-beta2', '2.0' ]
+    name: Lint ICU4X Rust executor
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.73
+          toolchain: "1.82"
           components: rustfmt, clippy
           default: true
       - uses: actions-rs/cargo@v1
@@ -31,4 +31,8 @@ jobs:
         with:
           command: fmt
           args: --manifest-path executors/rust/${{ matrix.icu4x-version }}/Cargo.toml -- --check
+      - name: "Run Rustfmt (executor code)"
+        run: rustfmt executors/rust/src/** --check
+      - name: "Run Rustfmt (common code)"
+        run: rustfmt executors/rust/common/** --check
 

.gitignore

@@ -1,15 +1,18 @@
 #*#
 *~
 *#
+*.#
 .vscode
 
+*Minibuf-*
+    
 .pylintrc
 .idea
 .devcontainer
 
 executors/rust/target/
 executors/cpp/executor
-executors/dart_native/bin/executor/
+executors/dart/bin/executor/
 
 gh-cache/
 
@@ -50,6 +53,3 @@ logrotate.state
 
 # Maven
 dependency-reduced-pom.xml
-
-# Dart
-executors/dart/.dart_tool/