Known issues in NodeJS datetime format (#520)

* Updating number format data generation and NodeJS number_fmt

* Updated C++ number format, fixing errors and failing tests

* Fix number format in ICU4J

* Remove cout

* Add halfOdd to possible test results

* Add dateTimeFormatType to datagen, schema, and CPP version

* Updating regex for unsupported test types.

* Updates as suggested

* Classify some datetime_fmt errors as known issues, fixing some ICU4C and ICU4J failures.

* Handle Node known issue for timezone only format

* responding to review suggestions

* DateTime checking known issues

* Removing schema change

* Removing change in cpp file

* Undoing unrelated change

* Remove extra check for comma

* Remove copy

* Reply to suggestions

* Restore check_list_differences

* Fix when result is missing

* Add timezone name differences to known issues

* Massaging values to check KI for UTC vs GMT

* Add continue statements

Author: Craig Cornelius

verifier/check_known_issues.py

@@ -62,6 +62,7 @@ class knownIssueType(Enum):
     datetime_semantic_Z = 'NodeJS always includes date or time'
 
     datetime_GMT_UTC = 'UTC instead of GMT'
+    datetime_TZ_name = 'Using different names of timezone'
 
     # Likely Subtags
     likely_subtags_sr_latn = "sr_latin becoming en"
@@ -108,6 +109,7 @@ def diff_ascii_space_vs_nbsp(actual, expected_value):
     if not expected_value or not actual:
         return None
 
+
     # Normalizing all NBSP spaces to ASCII in both to check if the type of space
     # is the only difference in formatted output.
     if actual.replace(NBSP, SP) == expected_value.replace(NBSP, SP):
@@ -207,6 +209,21 @@ def dt_inserted_comma(actual, expected):
 
 def dt_gmt_utc(actual, expected):
     # The difference may also include NBSP vs ASCII space
+    new_expected = expected.replace(NBSP, SP).replace(',', '')
+    new_actual = actual.replace(NBSP, SP).replace(' at', '').replace(',', '')
+
+    # Variant followed by standard
+    variations = [
+        ('UTC', 'GMT'),
+        ('Coordinated Universal Time', 'Greenwich Mean Time'),
+        ('توقيت غرينتش', 'التوقيت العالمي المنسق'),  # Arabic
+        ('เวลาสากลเชิงพิกัด', 'เวลามาตรฐานกรีนิช'),  # Thai
+        ('協定世界時', 'グリニッジ標準時'),  # Japanese
+    ]
+
+    for variation in variations:
+        if new_actual.find(variation[0]) >= 0 and new_actual.replace(variation[0], variation[1]) == new_expected:
+            return knownIssueType.datetime_GMT_UTC
     new_expected = expected.replace(NBSP, SP)
     new_actual = actual.replace(NBSP, SP)
 
@@ -232,8 +249,10 @@ def check_datetime_known_issues(test, platform_info):
         input_data = test.get('input_data')
 
         # Perform each test, computing matches with known issues by means of the functions in this list
-        check_fns = [dt_gmt_utc, diff_nbsp_vs_ascii_space, diff_ascii_space_vs_nbsp, numerals_replaced_by_another_numbering_system,
-                  dt_check_arabic_comma, dt_inserted_comma, dt_check_for_alternate_long_form]
+        check_fns = [dt_gmt_utc, diff_nbsp_vs_ascii_space, diff_ascii_space_vs_nbsp,
+                     numerals_replaced_by_another_numbering_system,
+                     dt_check_arabic_comma, dt_inserted_comma, dt_check_for_alternate_long_form]
+
         for check_fn in check_fns:
             is_ki = check_fn(result, expected)
             if is_ki:

verifier/testreport.py

@@ -834,7 +834,8 @@ def check_simple_text_diffs(self, test_list, category):
 
             if isinstance(actual, bool) and isinstance(expected, bool) and actual != expected:
                 results['boolean_diff'].add(label)
-
+                continue
+                
             if isinstance(actual, list) or isinstance(expected, list):
                 continue