Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make icu_harfbuzz be safe and no_std #3257

Closed
sffc opened this issue Apr 4, 2023 · 5 comments · Fixed by #4794
Closed

Make icu_harfbuzz be safe and no_std #3257

sffc opened this issue Apr 4, 2023 · 5 comments · Fixed by #4794
Assignees
@Manishearth
Labels
C-unicode Component: Props, sets, tries S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Milestone
2.x Priority ⟨P2⟩

Comments

@sffc
Copy link
Member

sffc commented Apr 4, 2023

If/when the upstream harfbuzz crate merges servo/rust-harfbuzz#197, we will be able to make icu_harfbuzz be both safe and no_std.
@sffc sffc added C-unicode Component: Props, sets, tries T-techdebt Type: ICU4X code health and tech debt blocked A dependency must be resolved before this is actionable S-small Size: One afternoon (small bug fix or enhancement) labels Apr 4, 2023
@sffc sffc added this to the Priority Backlog ⟨P3⟩ milestone Apr 4, 2023
@robertbastian robertbastian mentioned this issue Jul 19, 2023
Merged
@sffc
Copy link
Member Author

sffc commented Aug 1, 2023

I updated servo/rust-harfbuzz#197 such that the dependency is now std-optional. Just waiting on that upstream PR to be reviewed, merged, and shipped on crates.io.

@sffc sffc self-assigned this Aug 1, 2023
@sffc
Copy link
Member Author

sffc commented Sep 8, 2023

servo/rust-harfbuzz#197 is merged. We should be able to remove most or all of the unsafe FFI bindings on the icu4x side once the crate is released.

@sffc sffc mentioned this issue Dec 1, 2023
Open
@sffc sffc removed the blocked A dependency must be resolved before this is actionable label Dec 1, 2023
@sffc sffc mentioned this issue Feb 1, 2024
Merged
@sffc
Copy link
Member Author

sffc commented Feb 27, 2024

Waiting for upstream to make a release: servo/rust-harfbuzz#245

@Manishearth
Copy link
Member

A release just happened

@Manishearth Manishearth assigned Manishearth and unassigned sffc Apr 10, 2024
@Manishearth
Copy link
Member

Going to take a crack at updating to UnicodeFuncs

@Manishearth Manishearth mentioned this issue Apr 10, 2024
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
C-unicode Component: Props, sets, tries S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Projects
icu4x 2.0
Status: Done
Milestone
2.x Priority ⟨P2⟩
Development

Successfully merging a pull request may close this issue.

Switch to harfbuzz funcs Manishearth/icu4x
2 participants
@sffc @Manishearth