Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Priority Fallback logic for Preferences based on the marker INFO #5764

Closed
zbraniecki opened this issue Nov 2, 2024 · 1 comment · Fixed by #5779
Closed

Generate Priority Fallback logic for Preferences based on the marker INFO #5764

zbraniecki opened this issue Nov 2, 2024 · 1 comment · Fixed by #5779
Assignees
@zbraniecki

Comments

@zbraniecki
Copy link
Member

zbraniecki commented Nov 2, 2024 •
edited
Loading

Ideally this should be generated as well. The way to do this would be to add the
marker as a macro argument and branch on
<$marker>::INFO.fallback_config.priority

Originally posted by @robertbastian in #5729 (comment)
@zbraniecki zbraniecki self-assigned this Nov 2, 2024
@zbraniecki zbraniecki mentioned this issue Nov 2, 2024
Merged
@robertbastian
Copy link
Member

I have code for this in f3f1657

@robertbastian robertbastian mentioned this issue Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zbraniecki zbraniecki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert preferences to DataLocale robertbastian/icu4x
2 participants
@zbraniecki @robertbastian