-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmenter constructor options/preferences normalization #5856
Comments
If we were to reduce the number of constructors, I'm leaning toward option 3 to remove constructor set 2. I feel it is not too terrible to ask the user to pass Note: there is probably a naming inconsistency in |
@Manishearth @makotokato @zbraniecki, anything to add to the list above? What should we name the segmenter constructor that takes no arguments, uses compiled data, is infallible, and uses Unicode data with no CLDR locale tailorings? (It is currently named |
Not a huge fan of using the somewhat-CLDR-internal concept "root" in the name. |
I don't have strong opinions for this. Actually we have no plan to add new options. If we support auto-phase in css text, it can add it in css property. |
#5958 adds We can rename We should also figure out what we want to do with Grapheme. Grapheme does not support any tailorings right now, but it could in the future? I'm inclined to let Grapheme have a |
I like |
In #3284 we decided to add a
content_locale
option to segmenter.In #5839, @zbraniecki asked some questions about the signature of the constructors.
Currently we have constructors of the following shape:
new
: singleton static data (infallible), no content locale tailoringstry_new_unstable
: dynamic data, no content locale tailoringstry_new_with_options
: static data with content locale tailoringstry_new_with_options_unstable
: dynamic data with content locale tailoringsWhich of the following should we do?
with_options
.with_options
. Keep constructor 1 as a compiled data infallible optimization.And, should we take a
LanguageIdentifier
or a preferences bag for the content locale? (Please understand the discussion in #3284 before stating an opinion on this)@zbraniecki @makotokato @aethanyc @Manishearth
The text was updated successfully, but these errors were encountered: