Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move a few straggling dependencies to workspace Cargo.toml #5866

Open
sffc opened this issue Nov 23, 2024 · 0 comments
Open

Move a few straggling dependencies to workspace Cargo.toml #5866

sffc opened this issue Nov 23, 2024 · 0 comments
Labels
C-process Component: Team processes S-small Size: One afternoon (small bug fix or enhancement)
Milestone
ICU4X 2.0 Stretch...

Comments

@sffc
Copy link
Member

sffc commented Nov 23, 2024

As part of the 2.0.0-beta1 release checklist, I found a few crates that have dependencies that aren't in the workspace:

  • components/normalizer/fuzz
  • ffi/ecma402
  • ffi/freertos
  • tools/benchmark/macros
  • tools/benchmark/memory
  • tools/make/diplomat-coverage
  • utils/bies
  • utils/env_preferences
  • utils/potential_utf (dev deps)

Maybe some of these should start using workspace dependencies. For ones that don't, maybe explicitly say that they are excluded in the release checklist.
@sffc sffc added this to the ICU4X 2.0 Stretch ⟨P2⟩ milestone Nov 23, 2024
This was referenced Nov 23, 2024
Closed
Merged
Manishearth pushed a commit that referenced this issue Nov 23, 2024
@sffc
Use workspace deps in potential_utf (#5867)
f5d8074 
#5635
#5866
@Manishearth Manishearth added the S-small Size: One afternoon (small bug fix or enhancement) label Jan 7, 2025
@sffc sffc added the C-process Component: Team processes label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-process Component: Team processes S-small Size: One afternoon (small bug fix or enhancement)
Projects
None yet
Milestone
ICU4X 2.0 Stretch ⟨P2⟩
Development

No branches or pull requests
2 participants
@sffc @Manishearth