Allow validated issue status to be set in configuration

Author: brightcohen

README.md

@@ -33,9 +33,6 @@ The following environment variables are expected.  If a `.env` file is present,
 # Hostname of your Jira instance.
 JIRA_URL=unicode-org.atlassian.net
 
-# Hostname of your GitHub instance
-GITHUB_URL=https://github.mycompany.com/api/v3
-
 # Authentication for your Jira instance.
 # If not present, authentication for Jira will not be used.
 #
@@ -44,6 +41,9 @@ GITHUB_URL=https://github.mycompany.com/api/v3
 [email protected]
 JIRA_PASSWORD=bar
 
+# List of issue statuses that would be accepted
+JIRA_APPROVED_STATUSES="Approved, Progress"
+
 # URL prefix used for hyperlinks.
 URL_PREFIX=http://localhost:3000
 
@@ -65,6 +65,9 @@ [email protected]
 # Secret for the cookie session, used to store the user's GitHub access token in a cookie.
 COOKIE_SECRET=xxxxxxxxxx
 
+# Hostname of your GitHub instance
+GITHUB_URL=https://github.mycompany.com/api/v3
+
 # GitHub permissions:
 
 # Option 1: Personal Access Token; easiest and useful for testing.

app.js

@@ -74,11 +74,11 @@ async function getJiraInfo(pullRequest) {
 	const isMaintMerge = (pullRequest.base.ref === "master"
 		&& pullRequest.head.ref.match(/^maint\//)
 		&& pullRequest.base.repo.full_name == pullRequest.head.repo.full_name);
+	let jiraApprovedStatuses = process.env.JIRA_APPROVED_STATUSES || "Accepted, Reviewing, Review Feedback"
+	const jiraApprovedStatusesArray = jiraApprovedStatuses.split(",").map(status => status.trim())
 
 	// Check Jira ticket for validity
-	if (jiraStatus !== "Accepted" &&
-			jiraStatus !== "Reviewing" &&
-			jiraStatus !== "Review Feedback") {
+	if (!jiraApprovedStatuses.includes(jiraStatus)) {
 		return {
 			issueKey,
 			jiraStatus,
@@ -121,7 +121,7 @@ async function getJiraInfo(pullRequest) {
 		}
 	}
 
-	// Since we can't easilly check more than 100 commits, reject PRs with more than 100 commits
+	// Since we can't easily check more than 100 commits, reject PRs with more than 100 commits
 	if (commits.length === 100) {
 		return {
 			issueKey,