Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor check logic in SeriesSchemaBase.validate method #190

Open
cosmicBboy opened this issue Apr 3, 2020 · 0 comments
Open

refactor check logic in SeriesSchemaBase.validate method #190

cosmicBboy opened this issue Apr 3, 2020 · 0 comments

Comments

@cosmicBboy
Copy link
Collaborator

#189 revealed a bug in the series check logic that doesn't account for duplicated keys in the check object index. This seems like functionality to factor out into a pure function (static method would also do) so that it can be more easily tested for properties:

  • the number of rows/elements in _check_obj should be less than or equal to the number of elements in the series object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant