Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation #101

Open
fabienjuif opened this issue Oct 26, 2018 · 4 comments
Open

deprecation #101

fabienjuif opened this issue Oct 26, 2018 · 4 comments
Assignees

Comments

@fabienjuif
Copy link
Member

deprecate this lib, since Suspense is official: https://github.com/facebook/react/blob/master/CHANGELOG.md#1660-october-23-2018

@fabienjuif
Copy link
Member Author

  • add a npm warning
  • add a line into the README.md

@fabienjuif fabienjuif self-assigned this Oct 26, 2018
@ptitFicus
Copy link
Collaborator

Is the documentation already available for Suspense ? I did not found it (I mean except the React.lazy() part).
Moreover the Suspense issue is far from closed : facebook/react#13206.

Perhaps we could add a simple example of replacing this HOC with Suspense (depending of Suspense docs) ?

@fabienjuif
Copy link
Member Author

Yeah we should wait, I created the issue more as a reminder for now.

For now:

  • I wanted to fix the version 7.0.x because it seems buggy atm (cause of componentDidMount...)
  • I wanted to deprecate it, and ask people to use recompose (branch and lifecycle), or use them internally.

I don't know, what your though @ptitFicus?

@ptitFicus
Copy link
Collaborator

Ok, sorry I did not understand that it was for later, so I started to freak out ;).

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants