Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react / use hooks and new context API #263

Open
fabienjuif opened this issue Jan 8, 2019 · 5 comments
Open

react / use hooks and new context API #263

fabienjuif opened this issue Jan 8, 2019 · 5 comments
Labels
feature help wanted Extra attention is needed
Milestone
Next

Comments

@fabienjuif
Copy link
Member

  • once hooks will be stable
  • it will be a breaking change because we will drop support for react-redux
@fabienjuif fabienjuif assigned fabienjuif and unassigned fabienjuif Jan 8, 2019
@fabienjuif fabienjuif added help wanted Extra attention is needed feature labels Jan 10, 2019
@fabienjuif
Copy link
Member Author

Hooks are not released yet

@fabienjuif
Copy link
Member Author

Ok I got troll from Twitter: https://reactjs.org/blog/2019/02/06/react-v16.8.0.html
Hooks are released in 16.8

@fabienjuif fabienjuif added this to the 2.0.0 milestone Feb 6, 2019
@fabienjuif fabienjuif assigned fabienjuif and unassigned fabienjuif Feb 6, 2019
@fabienjuif fabienjuif modified the milestones: 2.0.0, Next Feb 6, 2019
@AFaugeras
Copy link
Collaborator

@fabienjuif do you need some help to update the library with hooks, or at least, to begin with, update the library so we don't have the warning about componentWillMount anymore?

@fabienjuif
Copy link
Member Author

Sure, but I think it should be 2 distincts PR, don't you think?
Do you want to look into this?

@AFaugeras
Copy link
Collaborator

Well, I can look into it for sure :)
And yes, 2 distincts PRs might be better ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted Extra attention is needed
Projects
None yet
Milestone
Next
Development

No branches or pull requests
2 participants
@AFaugeras @fabienjuif