-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API to add custom actions to state nodes #60
Comments
An other idea for the generation of action creators is to give a list of action name and generate an action type based on the path in a mobx-state-tree fashion const store = createStore({
data: {
nested: simpleObject({
actions: [ 'load', 'loaded' ]
}),
},
}
store.data.nested.loaded({ hello: 'world' })
// Dispatch {type: 'data/nested/loaded', payload: { hello: 'world' } } But I'm not entirely convince... It's difficult then to extend the list of actions to add a custom action creator function. A solution can be to have both API. If |
This is something to open to k-redux-factory first since k-redux-factory offers |
It could be useful to allow users to define their own custom actions along with the ones already generated by k-redux-factory.
The actions could be then decorated with dispatch function, allowing the user to easily call it from the store
Since we want to push the use of the redux-saga like API, we want to be able to dispatch very simple action like simple events. For this, our library can also help the user by generating actions for him. You just give a type name for your action and it generate the action creator for you. The action creators can take an optional payload that will be aded to the action.
I'm not entirely sure of the API. In particular, I'm not convinced by the
store.data.load.type
to get the type name of the action. Perhaps by adding atoString
implementation to the function ? Allowing to just dowhen(store.data.loaded, (...) => ...)
?The text was updated successfully, but these errors were encountered: