Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toast - review from master #97

Open
5 tasks done
fabienjuif opened this issue Jan 10, 2018 · 3 comments
Open
5 tasks done

toast - review from master #97

fabienjuif opened this issue Jan 10, 2018 · 3 comments

Comments

@fabienjuif
Copy link
Member

fabienjuif commented Jan 10, 2018

@fabienjuif
Copy link
Member Author

@vmenard @guillaumecrespel there still are 3 points to handle

@guillaumecrespel
Copy link
Member

guillaumecrespel commented Jan 10, 2018

  1. Kriya Button have not the same style / animation that toast button.
    But, i agree to add saga event on click.

  2. and broken code style with other container ?

  3. ok

@fabienjuif
Copy link
Member Author

  1. Maybe we should externalized this kind of button or add a type to our button component
  2. You still can do :
const mapStateToProps = (state) => {
 return getToast(state)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants