chore: rubocop

Author: ronaldtse

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2025-07-17 06:40:49 UTC using RuboCop version 1.78.0.
+# on 2025-07-17 07:21:41 UTC using RuboCop version 1.78.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -13,6 +13,14 @@ Gemspec/RequiredRubyVersion:
   Exclude:
     - 'unitsdb.gemspec'
 
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: with_first_argument, with_fixed_indentation
+Layout/ArgumentAlignment:
+  Exclude:
+    - 'lib/unitsdb/commands/qudt/updater.rb'
+
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyleAlignWith.
@@ -37,6 +45,13 @@ Lint/DuplicateBranch:
     - 'lib/unitsdb/commands/ucum/matcher.rb'
     - 'lib/unitsdb/database.rb'
 
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AutoCorrect.
+Lint/UselessAssignment:
+  Exclude:
+    - 'lib/unitsdb/commands/qudt/updater.rb'
+
 # Offense count: 87
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
@@ -182,14 +197,6 @@ Style/OptionalBooleanParameter:
     - 'lib/unitsdb/commands/ucum/check.rb'
     - 'lib/unitsdb/commands/ucum/updater.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowedMethods.
-# AllowedMethods: nonzero?
-Style/RedundantCondition:
-  Exclude:
-    - 'lib/unitsdb/commands/qudt/updater.rb'
-
 # Offense count: 1
 # Configuration parameters: Max.
 Style/SafeNavigationChainLength:

lib/unitsdb/commands/qudt/updater.rb

@@ -139,16 +139,12 @@ def get_original_yaml_file(_db_entities, output_file)
 
           # Try to find the original file in the database directory
           # Look for it relative to where we expect it to be
-          database_dir = nil
+          # nil
 
           # Try to get database directory from environment or assume it's the fixtures
-          if ENV["UNITSDB_DATABASE_PATH"]
-            database_dir = ENV["UNITSDB_DATABASE_PATH"]
-          else
-            # Default to the fixtures directory for testing
-            database_dir = File.join(File.dirname(__FILE__),
-                                     "../../../spec/fixtures/unitsdb")
-          end
+          database_dir = ENV["UNITSDB_DATABASE_PATH"] ||
+            File.join(File.dirname(__FILE__),
+                      "../../../spec/fixtures/unitsdb")
 
           original_yaml_file = File.join(database_dir, "#{entity_type}.yaml")