Skip to content

Commit 49315f2

Browse files
arnoutjacmet
authored andcommitted
Remove BR2_DEPRECATED
The BR2_DEPRECATED logic is a lot less useful than the legacy handling, because the symbols just disappears without warning to the user. For example, we had a few defconfigs that were using deprecated symbols (which were not actually used because BR2_DEPRECATED wasn't set) so these didn't build the expected code anymore. Also, the idea behind BR2_DEPRECATED is that you can easily revive it again if there is interest. However, it is relatively easy to revert the removal of a package as well. The deprecation is also more effort because it has to be removed twice: once when deprecating, and once when really removing. It doesn't make sense to add a legacy entry for BR2_DEPRECATED. Users who actually used it will get legacy warnings instead. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]> Signed-off-by: Peter Korsgaard <[email protected]>
1 parent 3534399 commit 49315f2

File tree

3 files changed

+0
-35
lines changed

3 files changed

+0
-35
lines changed

Config.in

-30
Original file line numberDiff line numberDiff line change
@@ -361,36 +361,6 @@ config BR2_CCACHE_USE_BASEDIR
361361

362362
endif
363363

364-
config BR2_DEPRECATED
365-
bool "Show options and packages that are deprecated or obsolete"
366-
help
367-
This option shows outdated/obsolete versions of packages and
368-
options that are otherwise hidden.
369-
370-
if BR2_DEPRECATED
371-
372-
config BR2_DEPRECATED_SINCE_2015_11
373-
bool
374-
default y
375-
376-
config BR2_DEPRECATED_SINCE_2016_02
377-
bool
378-
default y
379-
380-
config BR2_DEPRECATED_SINCE_2016_05
381-
bool
382-
default y
383-
384-
config BR2_DEPRECATED_SINCE_2016_08
385-
bool
386-
default y
387-
388-
config BR2_DEPRECATED_SINCE_2016_11
389-
bool
390-
default y
391-
392-
endif
393-
394364
config BR2_ENABLE_DEBUG
395365
bool "build packages with debugging symbols"
396366
help

Makefile

-2
Original file line numberDiff line numberDiff line change
@@ -436,9 +436,7 @@ all: world
436436

437437
# Include legacy before the other things, because package .mk files
438438
# may rely on it.
439-
ifneq ($(BR2_DEPRECATED),y)
440439
include Makefile.legacy
441-
endif
442440

443441
include package/Makefile.in
444442
include support/dependencies/dependencies.mk

Makefile.legacy

-3
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@
44
# This file contains placeholders to detect backward-compatibility problems.
55
# When a buildroot "API" feature is being deprecated, a rule should be added
66
# here that issues an error when the old feature is used.
7-
#
8-
# This file is not included if BR2_DEPRECATED is selected, so it is possible
9-
# to bypass the errors (although that's usually a bad idea).
107

118
ifeq ($(BR2_LEGACY),y)
129
$(error "You have legacy configuration in your .config! Please check your configuration.")

0 commit comments

Comments
 (0)