parallelfor: silence bogus uninitialized warnings

Author: fibodevy

compiler/pmodules.pas

@@ -40,7 +40,7 @@ implementation
 
     uses
        SysUtils,
-       globtype,systems,tokens,
+       globtype,systems,tokens,constexp,
        cutils,cfileutl,cclasses,comphook,
        globals,verbose,finput,fppu,globstat,fpcp,fpkg,
        symconst,symbase,symtype,symdef,symsym,symtable,defutil,symcreat,
@@ -1206,6 +1206,12 @@           current_module.rtti_directive.options:=class_tobject.rtti.options;
           cderefnode.create(ctypeconvnode.create_internal(
             cloadnode.create(psym,psym.owner),
             cpointerdef.getreusable(tprocvardef(curr.parfor_nested_pvd))))));
+        { the thread return value is never read, but leaving the result
+          unassigned makes dfa warn about an uninitialized function result
+          at the first parallel loop of the module }
+        addstatement(stat,cassignmentnode.create(
+          cloadnode.create(thunkpd.funcretsym,thunkpd.funcretsym.owner),
+          cordconstnode.create(0,ptrsinttype,false)));
         typecheckpass(body);
         thunkpi.code:=body;
         symtablestack.pop(thunkpd.localst);

compiler/pstatmnt.pas

@@ -2318,6 +2318,9 @@                        ((tsubscriptnode(hp).left.resultdef.typ=recorddef) or
               tidarrtype:=carraydef.create(0,255,s32inttype);
               tarraydef(tidarrtype).elementdef:=tidtype;
               partids:=parfor_make_local(old_procinfo.procdef,'$partids'+workerpd.unique_id_str,tidarrtype);
+              { only written element-wise in the spawn loop, which dfa cannot
+                prove covers the reads - keep it out of the uninitialized checks }
+              include(partids.varoptions,vo_is_internal);
               parkvar:=parfor_make_local(old_procinfo.procdef,'$park'+workerpd.unique_id_str,s32inttype);
 
               { caller side: set up the shared state, size the pool, spawn the