-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to generate favicon without padding and without background #190
Comments
@MartinZikmund is this on Windows? |
Yes seen it in our sample app in Edge on Windows, but it seems that the solid background is just part of the favicon itself |
The same should be for the WinUI project also, I think. When I was generating the icon, I needed to manually go to manifest and update it myself with the asset without padding and background. |
@MartinZikmund the scaling is defined in the definition of the base.props. I would assume if you updated this to something like the following you might achieve the result you're looking for: <PropertyGroup>
<UnoIconScale>0.65</UnoIconScale>
<UnoIconScale Condition="$(MSBuildProjectName.EndsWith('.Wasm')) or $(TargetFramework.Contains('-windows10'))">1.0</UnoIconScale>
</PropertyGroup>
<ItemGroup>
<UnoIcon Include="$(MSBuildThisFileDirectory)Icons\icon.svg"
ForegroundFile="$(MSBuildThisFileDirectory)Icons\icon_foreground.svg"
ForegroundScale="$(UnoIconScale)"
Color="#00000000" />
</ItemGroup> |
Will try this out |
When I set the color as "#00000000" in Ideally, we should make the background transparent by default in the template as on most targets 95% users will want exactly that |
Also, how does one configure icon and splash screen in single project? |
What would you like to be added:
Currently the background of the favicon is a solid color:
Why is this needed:
Make the icons nicer and more aligned with other websites
For which Platform:
Anything else we need to know?
The text was updated successfully, but these errors were encountered: