Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Uno.Resizetizer extension for icon should be conditionally generated #289

Open
jeromelaban opened this issue Jun 6, 2024 · 1 comment · May be fixed by #309
Open

The Uno.Resizetizer extension for icon should be conditionally generated #289

jeromelaban opened this issue Jun 6, 2024 · 1 comment · May be fixed by #309
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.

Comments

@jeromelaban
Copy link
Member

Current behavior

This icon extension is currently not generated if the icon files are not setup properly, causing hard-to-diagnose errors:

uno.resizetizer/src/Resizetizer/src/WindowIconGeneratorTask.cs

Line 8 in d565936

public class WindowIconGeneratorTask_V0 : Task

Expected behavior

We should either generate this extension always, or move this extension to Uno so that it's always available.
@jeromelaban jeromelaban added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Jun 6, 2024
@dansiegel
Copy link
Contributor

this should be addressed when Resizetizer is ported into Uno

@rajamatt rajamatt mentioned this issue Jun 6, 2024
Merged
7 tasks
@dansiegel dansiegel linked a pull request Aug 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Window title not shown when packaged unoplatform/uno.resizetizer
2 participants
@dansiegel @jeromelaban