Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TabBar] Use InfoBadge for TabBarItem badge support #1134

Open
kazo0 opened this issue May 14, 2024 · 4 comments · May be fixed by #1142
Open

[TabBar] Use InfoBadge for TabBarItem badge support #1134

kazo0 opened this issue May 14, 2024 · 4 comments · May be fixed by #1142
Assignees
@morning4coffe-dev
Labels
control/tabbar kind/enhancement New feature or request.

Comments

@kazo0
Copy link
Contributor

kazo0 commented May 14, 2024

We should change the API for TabBarItem to just have an InfoBadge property and use the InfoBadge in the template here
@kazo0 kazo0 added kind/enhancement New feature or request. control/tabbar labels May 14, 2024
@kazo0 kazo0 mentioned this issue May 14, 2024
Closed
1 task
@agneszitte
Copy link
Contributor

Related issue: unoplatform/Uno.Gallery#1106

@MartinZikmund
Copy link
Member

@morning4coffe-dev is handling this

@kazo0
Copy link
Contributor Author

kazo0 commented May 16, 2024

@agneszitte I can't seem to assign @morning4coffe-dev to this, can we add him to to users?

@Xiaoy312 Xiaoy312 assigned Xiaoy312 and unassigned Xiaoy312 May 16, 2024
@morning4coffe-dev morning4coffe-dev linked a pull request May 16, 2024 that will close this issue
Open
18 tasks
@agneszitte
Copy link
Contributor

@agneszitte I can't seem to assign @morning4coffe-dev to this, can we add him to to users?

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morning4coffe-dev morning4coffe-dev

Labels
control/tabbar kind/enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Use InfoBadge for TabBarItem badge support morning4coffe-dev/uno.toolkit.ui
5 participants
@MartinZikmund @Xiaoy312 @kazo0 @agneszitte @morning4coffe-dev