Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Uno.Extensions.Maui.WinUI.Markup automatically if they use MAUI and C# markup #18700

Open
1 of 6 tasks
LuisAlfredo92 opened this issue Nov 5, 2024 · 1 comment · May be fixed by #18703
Open
1 of 6 tasks

Adding Uno.Extensions.Maui.WinUI.Markup automatically if they use MAUI and C# markup #18700

LuisAlfredo92 opened this issue Nov 5, 2024 · 1 comment · May be fixed by #18703
Labels
kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification

Comments

@LuisAlfredo92
Copy link

What would you like to be added:

Adding Uno.Extensions.Maui.WinUI.Markup automatically automatically when you use MAUI Embedding and C# Markup

Why is this needed:

Not to have to install it manually and deal with versions that can cause problems with Uno.Extensions.Maui.WinUI, and to be there since the beginning when creating a C# Markup project like other extensions

For which Platform:

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renders for Xamarin.Forms
  • Windows
  • Build tasks

Anything else we need to know?

I can add it myself, I'll do it

@LuisAlfredo92 LuisAlfredo92 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification labels Nov 5, 2024
@jeromelaban jeromelaban transferred this issue from unoplatform/uno.templates Nov 5, 2024
@jeromelaban
Copy link
Member

Thanks for the report and effort to make a contribution!

This is a change that needs to be made in unoplatform/uno. It's managed directly by this block:

<ItemGroup Condition="$(UnoFeatures.Contains(';csharpmarkup;'))">
<_UnoProjectSystemPackageReference Include="Uno.WinUI.Markup" ProjectSystem="true" />
<_UnoProjectSystemPackageReference Include="Uno.Extensions.Markup.Generators" ProjectSystem="true" />
</ItemGroup>

And most likely needs an additional block that checks for maui as well.

LuisAlfredo92 added a commit to LuisAlfredo92/uno that referenced this issue Nov 7, 2024
Adding MAUI and C# Markup packages when they are selected in templates. Also, found a probable typo that could cause the original problem

refs: unoplatform#18700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
2 participants