Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Replace iconify icons with radix-icons/vue for NewYork style #84

Closed
2 tasks
zernonia opened this issue Sep 25, 2023 · 2 comments · Fixed by #87
Closed
2 tasks

[Feature]: Replace iconify icons with radix-icons/vue for NewYork style #84

zernonia opened this issue Sep 25, 2023 · 2 comments · Fixed by #87
Assignees
@zernonia
Labels
good first issue Good for newcomers

Comments

@zernonia
Copy link
Member

zernonia commented Sep 25, 2023 •
edited by ahmedmayara
Loading

Describe the feature

Using iconify icons causing some confusion after installing new-york style, and hard to setup because it requires a few deps and configuration on vite.config. Thus changing the icons into newly published https://www.npmjs.com/package/radix-icons would solved that issue

Additional information

  • I intend to submit a PR for this feature.
  • I have already implemented and/or tested this feature.
@zernonia zernonia added the good first issue Good for newcomers label Sep 25, 2023
@SamantaTarun
Copy link

SamantaTarun commented Sep 25, 2023 •
edited
Loading

Could you please brifely describe it over here?

@sadeghbarati
Copy link
Collaborator

Probably good to add in the docs

The difference between Icon packages with Icon tools like

PureCSS icons

Icon Components

https://iconly-and-iconify.vercel.app (Custom iconset with unocss-preset-icon)
source

@zernonia zernonia self-assigned this Sep 27, 2023
@zernonia zernonia linked a pull request Sep 27, 2023 that will close this issue
refactor: replace iconify icons with @radix-icons/vue for newyork style #87
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zernonia zernonia

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: replace iconify icons with @radix-icons/vue for newyork style unovue/shadcn-vue
4 participants
@sadeghbarati @SamantaTarun @zernonia @ahmedmayara