Skip to content

use <?php instead of <? #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mauran opened this issue Jan 5, 2018 · 6 comments
Closed

use <?php instead of <? #9

mauran opened this issue Jan 5, 2018 · 6 comments
Assignees
@mauran @kaspergrubbe @olidotjpeg @boserup @emilstahl
Labels
enhancement

Comments

@mauran
Copy link
Contributor

mauran commented Jan 5, 2018

I think we should support as many PHP configurations as possible. Per default shorthand <? isn't supported on most fresh PHP installations. We should probably change it to <?php instead. I would really like to hear your opinion about this, @kaspergrubbe.
@boserup
Copy link
Member

boserup commented Jan 5, 2018 •
edited
Loading

We should update the readme to include installation and configuration instructions. It would then be appropriate to mention the requirement of enabling short_open_tag in php.ini.

@olidotjpeg
Copy link
Contributor

Make a merge-request

@mauran
Copy link
Contributor Author

mauran commented Oct 9, 2018

I am going to make a 10/10 merge request

@Steiniche
Copy link
Contributor

@mauran looking forward to it!

@onbjerg
Copy link
Contributor

onbjerg commented Oct 10, 2018

How do I make a merge request

@mauran
Copy link
Contributor Author

mauran commented Oct 13, 2018

Doing this takes an amount effort that I don't own. @onbjerg can you do this for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauran mauran

@kaspergrubbe kaspergrubbe

@olidotjpeg olidotjpeg

@boserup boserup

@emilstahl emilstahl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@mauran @kaspergrubbe @olidotjpeg @boserup @Steiniche @emilstahl @onbjerg