Skip to content

Commit 147bbde

Browse files
committed
db/lib/sqlbuilder: ignore order when counting
1 parent 328c184 commit 147bbde

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

Diff for: lib/sqlbuilder/paginate.go

+5-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,11 @@ func newPaginator(sel Selector, pageSize uint) Paginator {
3939

4040
func (pq *paginatorQuery) count() (uint64, error) {
4141
var count uint64
42-
row, err := pq.sel.(*selector).setColumns(db.Raw("count(1) AS _t")).Limit(0).Offset(0).QueryRow()
42+
row, err := pq.sel.(*selector).setColumns(db.Raw("count(1) AS _t")).
43+
Limit(0).
44+
Offset(0).
45+
OrderBy(nil).
46+
QueryRow()
4347

4448
err = row.Scan(&count)
4549
if err != nil {

Diff for: lib/sqlbuilder/select.go

+7
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,13 @@ func (sel *selector) GroupBy(columns ...interface{}) Selector {
242242

243243
func (sel *selector) OrderBy(columns ...interface{}) Selector {
244244
return sel.frame(func(sq *selectorQuery) error {
245+
246+
if len(columns) == 1 && columns[0] == nil {
247+
sq.orderBy = nil
248+
sq.orderByArgs = nil
249+
return nil
250+
}
251+
245252
var sortColumns exql.SortColumns
246253

247254
for i := range columns {

0 commit comments

Comments
 (0)