Skip to content

Post-v0.4.0 polish: review follow-ups from the list/show redesign #2

Description

@usmanbashir

Collected from the per-task and final whole-branch reviews of the v0.4.0 list/show redesign. Every item was explicitly triaged non-blocking — the logic behind the test gaps was verified live during review; these tighten the net for future changes. File references are as of c12c58e.

Behavior edges

  • Project [efforts] replacement skews link accounting. familyStates (commands.go) builds the letter family from the effective ladder while linkable comes from the global token set, so a project ladder (e.g. only digit 6) leaves the model row warning not linked — run clau link forever — link is global-only and will never create co6 — and skews the footer denominator. Shipped as a comment only (baf3f23); a real fix derives the family's linkable digits from the global ladder.
  • contractHome (style.go) doesn't resolve symlinks between the path and $HOME, so a home reached via a different symlinked path won't tilde-contract. Display-only.
  • stdoutIsTTY (style.go) treats /dev/null as a TTY (ModeCharDevice), so redirecting to it emits discarded ANSI codes. Standard cheap heuristic; cosmetic.

Test tightening

  • TestContractHome: no case for p == home~.
  • TestRowBadges: covers 5 of 8 boolean combos; notably missing linked-but-unlinkable (an orphaned link no longer in the global set).
  • TestFamilyStates: never exercises a no-efforts letter (h).
  • kindLine: the plain profile branch (no extends) has no in-suite test.
  • TestMaskedEnvName: no plural-exclusion cases for KEY/SECRET/PASSWORD (KEYS, SECRETS, PASSWORDS must stay visible) and no mid-name segment case (TOKEN_EXPIRY must mask).
  • TestShowViewProjectSourceAndLinked: the linked no substring assertion can't tell which hint branch fired (run-clau-link vs project shortcut).
  • Completions tests assert show presence only, not verb-list placement or membership in the run/show token-completion branch.
  • digitSpan (commands.go) relies on single-digit effort keys enforced far away by effortKeyRe (config.go); add a local comment noting the coupling.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions