Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pid_controlのメンバ変数の秘匿化 #44

Open
200km opened this issue Apr 15, 2023 · 0 comments
Open

pid_controlのメンバ変数の秘匿化 #44

200km opened this issue Apr 15, 2023 · 0 comments
Labels
🚗 priority::low priority low 🐬 minor update Minor update
Milestone
v11.0.0 update

Comments

@200km
Copy link
Member

200km commented Apr 15, 2023

概要

pid_controlのメンバ変数の秘匿化

詳細

今の設計だと，PidControlのインスタンスをApp側で持つ，という性質上，previous_obc_timeとかいろいろいじれてしまう
privateなメンバの末尾に _ をつけておくだけでいいと思う．理想的には全部privateにして，getter/setter経由にしておくのが，今後のリファクタなどに強くなる

close条件

実装したら

備考

NA

注意

NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚗 priority::low priority low 🐬 minor update Minor update
Projects
None yet
Milestone
v11.0.0 update
Development

No branches or pull requests
1 participant
@200km