Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pqxx 7 #3

Open
Tobias-Fischer opened this issue Apr 23, 2021 · 2 comments
Open

Support for pqxx 7 #3

Tobias-Fischer opened this issue Apr 23, 2021 · 2 comments

Comments

@Tobias-Fischer
Copy link
Contributor

Tobias-Fischer commented Apr 23, 2021

At the moment the project cannot be compiled with libpqxx7 as there are lots of build errors, e.g.

$SRC_DIR/ros-noetic-knowledge-representation/src/work/src/libknowledge_rep/LongTermMemoryConduitPostgreSQL.cpp:134:21: error: 'using work = class pqxx::transaction<>' {aka 'class pqxx::transaction<>'} has no member named 'parameterized'

This is because deprecated methods were removed, see e.g. jtv/libpqxx@06ee045

It would be great if you could have a look. We are trying to add knowledge-representation to RoboStack which combines ROS with Conda: RoboStack/ros-noetic#116 (this is to the PR where you will also find a full build log)

@nickswalker
Copy link
Member

Thanks for raising this. I believe I've been seeing the deprecation warnings when building with 6.4, which is the version of libpqxx in focal/noetic. Is there a reason you're looking to use libpqxx 7? I'm not sure how to go about adopting the new query interface while maintaining compatibility with current ROS 1 releases.

@Tobias-Fischer
Copy link
Contributor Author

I ported the newest libpqxx (7) to conda-forge and was running into problems compiling. In the meantime I back-ported libpqxx 6 to conda-forge, and using this version I can now compile knowledge-representation in RoboStack. I guess at some point Ubuntu will roll over to libpqxx 7 as well, so best to be prepared ;). You could use their defined macros to check for the version at build time: https://github.com/jtv/libpqxx/blob/master/include/pqxx/version.hxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants