Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes on updating example-aster_stereo_reconstruction.ipynb #9

Open
dshean opened this issue Apr 9, 2024 · 2 comments
Open

Notes on updating example-aster_stereo_reconstruction.ipynb #9

dshean opened this issue Apr 9, 2024 · 2 comments

Comments

@dshean
Copy link
Member

dshean commented Apr 9, 2024

Just running this as a test and noticed it was still calling stereo for the ASTER example - we should update to parallel_stereo

Also, might be good to give people approximate runtimes in the doc above the cells running stereo/parallel_stereo, so they know how long to wait. I was seeing ~2.5-3 m for all stereo runs (regardless of camera model type) on codespaces.

Should be clear that these are images from the ASTER VNIR instrument.

Maybe we can include the new --aster-use-csm option (https://stereopipeline.readthedocs.io/en/latest/examples/aster.html#using-the-csm-model). Possibly even jitter_solve?

It could also make sense to keep the intro/example tutorial relatively simple, and have a second notebook for the more advanced processing, potentially with a difference map for the output DEMs from different camera models.

There are some other typos, but can review later. No rush on this, just wanted to jot down some notes.

@ShashankBice
Copy link
Member

ShashankBice commented Apr 11, 2024

Agreed, parallel_stereo will be added soon when i add examples for running correlation using different schemes in a different tutorial.

I would like to add use csm and jitter_solve in round 2, as advanced usage, when the first round of entry level examples are complete :)

@ShashankBice
Copy link
Member

will add note on run-times for cells, great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants