New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rotation matrix directly? #11

Open

adehecq opened this issue Nov 23, 2020 · 0 comments

adehecq commented Nov 23, 2020

In this function, the quaternion are not used at all. You could directly use the rotation matrix from ASP, no?

skysat_stereo/scripts/optimise_raw_camera.py

Line 37 in 078b44e

quaternion = Quaternion(q1,q2,q3,q4)

Additionally, for the quaternion, you could possibly use scipy rather than a third-party library: https://docs.scipy.org/doc/scipy/reference/generated/scipy.spatial.transform.Rotation.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment