Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in ASP pipeline "cam_gen" dependency #15

Open
andylai2 opened this issue Jul 21, 2021 · 3 comments
Open

Error in ASP pipeline "cam_gen" dependency #15

andylai2 opened this issue Jul 21, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@andylai2
Copy link

I downloaded ASP 2.6.2 as mentioned in the README. The skysat_stereo pipeline calls cam_gen with a --parse-ecef flag, but I get the following error:

Error parsing input:
unrecognised option '--parse-ecef'

Is this a versioning error?

@ShashankBice
Copy link
Member

Hi andylai2,
Yes, you are right, the version we use is post the 2.6.2 stable release. Using ASP 2.7.0 stable release will work without breaking the functions in this library. I will update this in the readme/documentation.
Thanks for taking interest in the code, let me know how it works for you.
Shashank

@ShashankBice ShashankBice added the documentation Improvements or additions to documentation label Jul 21, 2021
@andylai2
Copy link
Author

Thanks Shashank, I see that 2.7.0 was actually specified in the README but 2.6.2 was in the linked install instructions. 2.7.0 worked for me.

Is there a plan to update to ASP 3.0.0? I think that Planet has changed the formatting for the collect data and the data I am working with, collected this year, required some amount of hackiness to get skysat_stereo to run. For example, this issue came up as well as some other more minor ones.

Thank you!

@ShashankBice
Copy link
Member

ShashankBice commented Aug 11, 2021

Hi Andy,
Glad you got things to work ! I am aware that Planet has changed nomenclature for the video product, but I have not played with any of the datasets. We do interact with them regularly, so I will ask for a latest sample to take a quick look. Also, apart for the polygon orientation and nomenclature, it would be great if you could list the other hacks you had to do, it would really save some of my time ! I can then add the modifications to the next release.

Yes, there is a plan to upgrade to ASP 3.0. Oleg improved the least square solver in the latest release: https://github.com/NeoGeographyToolkit/StereoPipeline/blob/master/NEWS.rst (see under misc). I tested this and it works better for camera resection procedure for the triplets, where we use the RPC model to project rays from the image onto the DEM. But there has been a lot of other modifications with stereo correlators, and the new stereo correlators do not work well with the orthorectified workflow we have in here. So it will take me some time to test and adapt here the new options.

Meanwhile, these are the things i have worked (working) on, which will be in the next release. Then I can study the new ASP correlators and add in the next one :) .

Thanks,
Shashank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants