Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very rough initial implementation of generic GPIO. I spent some time earlier trying to get it working with an "actual" vtable and it was getting relatively complex since the different GPIO functions don't have the same signature and we'd need double function pointers or an intermediate function or something.
For this implementation the
GenGpioAddress
struct just holds pointers to all possible types, as well as aGenGpioType
enum that defines the type it represents. Then when we call a generic GPIO function on it we can use a switch to route to the correct function call. I think this should be close to a vtable implementation in terms of speed and memory usage.Notes: