Remove support for discontinued services (chirb.it and sassmeister.com)#6
Merged
Remove support for discontinued services (chirb.it and sassmeister.com)#6
Conversation
The chirb.it audio sharing service is no longer accessible (connection failure). This commit removes all related code and test files. Changes: - Remove chirb.it from oEmbed providers list - Remove test case from PagesTest - Delete cached responses and test fixtures 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The sassmeister.com Sass playground service is no longer accessible (DNS resolution failure). This commit removes the adapter, related code, and test files. Changes: - Remove Sassmeister adapter from ExtractorFactory - Delete Sassmeister adapter directory (Extractor and Code detector) - Remove testSassmeister() from PagesTest - Delete cached responses and test fixtures 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
WalkthroughSassMeister アダプター と chirb.it oEmbed エンドポイントのサポートを削除します。削除される変更には、SassMeister アダプタークラス、そのディテクター、アダプタファクトリマッピング、oEmbed エンドポイント設定、関連テスト、および関連するテストフィクスチャが含まれます。 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 分
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro Knowledge base: Disabled due to 📒 Files selected for processing (10)
💤 Files with no reviewable changes (10)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes support for two services that have been shut down and are no longer accessible:
Services Status Evidence
chirb.it (Chirbit)
sassmeister.com (SassMeister)
Changes Made
chirb.it removal:
src/resources/oembed.phptests/PagesTest.phpsassmeister.com removal:
src/ExtractorFactory.phpsrc/Adapters/Sassmeister/directory (Extractor and Code detector)testSassmeister()test method fromtests/PagesTest.phpref
Summary by CodeRabbit
リリースノート
✏️ Tip: You can customize this high-level summary in your review settings.