Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Build is failing #414

Open
ackava opened this issue May 30, 2020 · 0 comments
Open

iOS Build is failing #414

ackava opened this issue May 30, 2020 · 0 comments
Labels

Comments

@ackava
Copy link

ackava commented May 30, 2020

Build fails after following instructions on https://v8.dev/docs/cross-compile-ios,

../third_party/inspector_protocol/crdtp/json.cc:290:18: error: implicit conversion from 'std::__1::numeric_limits<long long>::type' (aka 'long long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-const-int-float-conversion]
    if (value <= std::numeric_limits<int64_t>::max() &&
              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../third_party/inspector_protocol/crdtp/json.cc:107:3: note: in instantiation of member function 'v8_crdtp::json::(anonymous namespace)::JSONEncoder<std::__1::vector<unsigned char, std::__1::allocator<unsigned char>>>::HandleDouble' requested here
  JSONEncoder(C* out, Status* status) : out_(out), status_(status) {
  ^
../third_party/inspector_protocol/crdtp/json.cc:365:11: note: in instantiation of member function 'v8_crdtp::json::(anonymous namespace)::JSONEncoder<std::__1::vector<unsigned char, std::__1::allocator<unsigned char>>>::JSONEncoder' requested here
      new JSONEncoder<std::vector<uint8_t>>(out, status));
          ^
../third_party/inspector_protocol/crdtp/json.cc:290:18: error: implicit conversion from 'std::__1::numeric_limits<long long>::type' (aka 'long long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-const-int-float-conversion]
    if (value <= std::numeric_limits<int64_t>::max() &&
              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../third_party/inspector_protocol/crdtp/json.cc:107:3: note: in instantiation of member function 'v8_crdtp::json::(anonymous namespace)::JSONEncoder<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>::HandleDouble' requested here
  JSONEncoder(C* out, Status* status) : out_(out), status_(status) {
  ^

Github Action:
https://github.com/ackava/v8-android-buildscripts/runs/722913223?check_suite_focus=true

Is there any option to ignore this warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants