Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v-drag-over-target is not removed when the drop is ending in a nested drop target #20607

Open
enver-haase opened this issue Dec 3, 2024 · 1 comment
Open

v-drag-over-target is not removed when the drop is ending in a nested drop target #20607

enver-haase opened this issue Dec 3, 2024 · 1 comment
Assignees
@mshabarov
Labels
bug dnd Impact: Low regression Severity: Major

Comments

@enver-haase
Copy link
Contributor

Description of the bug

When #20231 was fixed, the fix unfortunately broke the case where a drop target is nested in (added to) another drop target.

Expected behavior

The application should work just like it did in 24.5.0 .

Minimal reproducible example

Screenshot 2024-12-03 at 12 07 49
Screenshot 2024-12-03 at 12 09 12

Versions

  • Vaadin / Flow version: Vaadin 24.5.6
@tepi tepi moved this to 🆕 Needs triage in Vaadin Flow bugs & maintenance (Vaadin 10+) Dec 4, 2024
@tepi tepi added the regression label Dec 4, 2024
@mshabarov mshabarov moved this from 🆕 Needs triage to 🔖 Normal Priority (P2) in Vaadin Flow bugs & maintenance (Vaadin 10+) Dec 4, 2024
@mshabarov mshabarov moved this to 🪵Product backlog in Vaadin Flow ongoing work (Vaadin 10+) Dec 4, 2024
@mshabarov mshabarov added the dnd label Dec 10, 2024
@mshabarov mshabarov moved this from 🪵Product backlog to 🟢Ready to Go in Vaadin Flow ongoing work (Vaadin 10+) Dec 11, 2024
@probert94
Copy link

I am facing the same problem in Vaadin 24.4.20. In the version we used before (24.4.14) it was still working.
The class for nested drop targets is only removed when the drop happens on them. So if you drag over 4 nested drop targets and drop it on one of them, 3 still keep the class

@mshabarov mshabarov self-assigned this Dec 20, 2024
@mshabarov mshabarov moved this from 🟢Ready to Go to ⚒️ In progress in Vaadin Flow ongoing work (Vaadin 10+) Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshabarov mshabarov

Labels
bug dnd Impact: Low regression Severity: Major
Projects
Vaadin Flow bugs & maintenance (Vaadin 10+)
Status: 🔖 Normal Priority (P2)
Vaadin Flow ongoing work (Vaadin 10+)
Status: ⚒️ In progress
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tepi @enver-haase @probert94 @mshabarov