-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing failed for browser and os versions reported to stdout #20610
Comments
As for issue 2, in this change this Artur guy explains why stderr is used instead of logging: 791b91c#diff-7354528a0f72607f3d6e1464b30a1fec4ca251c4cda835f7693bdd7cd5159e2bR568-R573 |
Always that guy. He is often wrong. Pretty good if nobody noticed or cared for 8 years though |
Added new opera userAgent string. Better logging for failures. Better matching for version string. Fixed android mistaken check. Part of #20610
I guess the stderr is because it is also used from the client and Logger is not available there. What is the logging choice we should use for the shared package that would work both for the server and client? |
There probably is no such thing and it should be logged in different ways on different sides |
Added new opera userAgent string. Better logging for failures. Better matching for version string. Fixed android mistaken check. Part of #20610
* fix: browser parsing Added new opera userAgent string. Better logging for failures. Better matching for version string. Fixed android mistaken check. Part of #20610 * Add ios firefox parsing Add isIPad Add testing userAgent strings from json file.
* fix: browser parsing Added new opera userAgent string. Better logging for failures. Better matching for version string. Fixed android mistaken check. Part of #20610 * Add ios firefox parsing Add isIPad Add testing userAgent strings from json file.
We've merged the patch, let's keep it opened until we release a new version and use it for a while with Start to see if we have a proper logging now and any remaining errors. |
* fix: browser parsing Added new opera userAgent string. Better logging for failures. Better matching for version string. Fixed android mistaken check. Part of #20610 * Add ios firefox parsing Add isIPad Add testing userAgent strings from json file. Co-authored-by: caalador <[email protected]>
Description of the bug
From logs of Start:
There seems to be two issues here:
Also as the full string that is being parsed is not logged in all cases, it makes things a bit difficult to fix
Expected behavior
No errors are logged without a logger and parsing succeeds
Minimal reproducible example
Versions
The text was updated successfully, but these errors were encountered: