Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jackson for public API and implementation instead of Elemental #20741

Open
mshabarov opened this issue Dec 18, 2024 · 1 comment
Open

Use Jackson for public API and implementation instead of Elemental #20741

mshabarov opened this issue Dec 18, 2024 · 1 comment

Comments

@mshabarov
Copy link
Contributor

mshabarov commented Dec 18, 2024

Describe your motivation

Jackson library (com.fasterxml.jackson) is more popular than Elemental (elemental.json), thus Vaadin should better use it in public API.

Describe the solution you'd like

  1. Add an adapter code that converts Jackson to/from Elemental
  2. Change Flow internal implementation to use Jackson
  3. Deprecate existing public method with Elemental
  4. Add same methods but that use Jackson
  5. Remove Elemental variants in next major version.

0 can be skipped if it's easier do 1. right away.

@knoobie
Copy link
Contributor

knoobie commented Dec 18, 2024

Just a note: I would suggest to implement some low level tests that Jaxkson does what you think it does.. I'm saying this because of their kinda "fast" releases the last years - which can sometimes break things.. so it might be worth to improve coverage in that area - especially with different Jackson versions in client projects and an upcoming new Jackson major (soon TM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🅿️Parking lot
Development

No branches or pull requests

2 participants