Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow is not buildable with Maven 4 #20742

Open
edler-san opened this issue Dec 18, 2024 · 0 comments
Open

Flow is not buildable with Maven 4 #20742

edler-san opened this issue Dec 18, 2024 · 0 comments

Comments

@edler-san
Copy link
Contributor

Description of the bug

I have been testing Maven 4 RC2 on the flow project and it fails due to stricter rules on the usage of expressions.

[ERROR]   The project [inherited]:flow-project:pom:24.7-SNAPSHOT (C:\Users\foobar\Documents\GitHub\flow\pom.xml) has 3 errors
[ERROR]     'repositories.repository.[${flow.release.repo.id}].url' contains an expression but should be a constant. @ com.vaadin:flow-project:24.7-SNAPSHOT, file:///C:/Users/foobar/Documents/GitHub/flow/pom.xml, line 165, column 13
[ERROR]     'repositories.repository.[${flow.addons.repo.id}].url' contains an expression but should be a constant. @ com.vaadin:flow-project:24.7-SNAPSHOT, file:///C:/Users/foobar/Documents/GitHub/flow/pom.xml, line 172, column 13
[ERROR]     'pluginRepositories.pluginRepository.[${flow.release.repo.id}].url' contains an expression but should be a constant. @ com.vaadin:flow-project:24.7-SNAPSHOT, file:///C:/Users/foobar/Documents/GitHub/flow/pom.xml, line 191, column 13

Now, while that is easily fixable it reveals a lot of issues in upstream projects. (Output after fixing the above.)

[ERROR] Plugin org.apache.karaf.tooling:karaf-maven-plugin:4.3.9 or one of its dependencies could not be resolved:
[ERROR]         30 problems were encountered while building the effective model for org.apache.karaf.tooling:karaf-maven-plugin:maven-plugin:4.3.9
[ERROR]     - [ERROR] recursive variable reference: scm.connection
[ERROR]     - [ERROR] recursive variable reference: scm.developerConnection
[ERROR]     - [ERROR] recursive variable reference: scm.url
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.maven:maven-plugin-api:jar is missing. @ line 63, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.maven:maven-artifact:jar is missing. @ line 83, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.maven:maven-core:jar is missing. @ line 87, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.maven:maven-compat:jar is missing. @ line 97, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.maven.wagon:wagon-http:jar is missing. @ line 112, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.karaf:org.apache.karaf.util:jar is missing. @ line 116, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.slf4j:slf4j-jdk14:jar is missing. @ line 125, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.felix:maven-bundle-plugin:jar is missing. @ line 139, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.felix:org.apache.felix.fileinstall:jar is missing. @ line 175, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.features:org.apache.karaf.features.core:jar is missing. @ line 179, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.profile:org.apache.karaf.profile.core:jar is missing. @ line 189, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.felix:org.apache.felix.resolver:jar is missing. @ line 193, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.ops4j.pax.url:pax-url-wrap:jar:uber is missing. @ line 203, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.ops4j.pax.url:pax-url-aether:jar is missing. @ line 208, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.ops4j.pax.url:pax-url-war:jar:uber is missing. @ line 212, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.deployer:org.apache.karaf.deployer.spring:jar is missing. @ line 217, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.deployer:org.apache.karaf.deployer.blueprint:jar is missing. @ line 221, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.deployer:org.apache.karaf.deployer.features:jar is missing. @ line 225, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.deployer:org.apache.karaf.deployer.kar:jar is missing. @ line 229, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.kar:org.apache.karaf.kar.core:jar is missing. @ line 233, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.shell:org.apache.karaf.shell.console:jar is missing. @ line 237, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.karaf:org.apache.karaf.main:jar is missing. @ line 241, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.karaf.diagnostic:org.apache.karaf.diagnostic.boot:jar is missing. @ line 245, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.commons:commons-compress:jar is missing. @ line 249, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.osgi:osgi.core:jar is missing. @ line 253, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for org.apache.xbean:xbean-finder-shaded:jar is missing. @ line 258, column 9
[ERROR]     - [ERROR] 'dependencies.dependency.version' for jakarta.xml.bind:jakarta.xml.bind-api:jar is missing. @ line 262, column 9: Failed to read artifact descriptor for org.apache.karaf.tooling:karaf-maven-plugin:jar:4.3.9

Expected behavior

The build succeeding.

Minimal reproducible example

Check out flow repository and run mvn package using the latest Maven 4 release candidate.

Versions

  • Vaadin / Flow version: 24.6, 24.7-SNAPSHOT
  • Java version: 17.0.13
  • OS version: Win 11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant