Skip to content

Commit aff71ab

Browse files
committed
fix(ci): remove invalid hashFiles() job-level guard in nightly.yml
hashFiles() is not available at the job-level if: condition — it runs before actions/checkout so the workspace is empty and GitHub Actions rejects it as an unrecognized function. The guard was a placeholder for Story 6.5 which has since landed; the feature_check step already gates all subsequent steps cleanly.
1 parent 135f80f commit aff71ab

1 file changed

Lines changed: 6 additions & 16 deletions

File tree

.github/workflows/nightly.yml

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
1-
# Placeholder until Story 6.5 ships tests/mainnet_smoke.rs and the
2-
# mainnet-smoke cargo feature. The job is fully gated on the existence of
3-
# `tests/mainnet_smoke.rs` so the cron stays a no-op until then — without
4-
# the guard, the cron would be permanently red on Day 1 because the feature
5-
# and the test file do not yet exist.
61
name: Nightly Mainnet Smoke
72

83
on:
@@ -38,24 +33,19 @@ jobs:
3833
# level forces job status to success and silently kills the notification
3934
# path.
4035
#
41-
# Soft-gate: this workflow is a no-op until Story 6.5 ships the test file
42-
# AND the `mainnet-smoke` cargo feature. Without this guard,
43-
# `cargo test --features mainnet-smoke` would error out with
44-
# "feature `mainnet-smoke` does not exist" and the cron would be red.
45-
if: hashFiles('tests/mainnet_smoke.rs') != ''
36+
# The `Verify mainnet-smoke cargo feature exists` step below gates all
37+
# subsequent steps — if the cargo feature is absent it short-circuits
38+
# cleanly without failing the workflow.
4639
steps:
4740
- uses: actions/checkout@v4
4841
with:
4942
fetch-depth: 1
5043
- name: Verify mainnet-smoke cargo feature exists
5144
id: feature_check
52-
# Belt-and-braces guard alongside the job-level `hashFiles` check —
5345
# `tests/mainnet_smoke.rs` and `[features] mainnet-smoke = []` may
54-
# land in separate PRs, and the cargo feature must exist before
55-
# `cargo test --features mainnet-smoke` is run. We set an output
56-
# rather than failing the step so the rest of the job can short-
57-
# circuit cleanly via `if:` (GitHub Actions has no native "skip"
58-
# exit code).
46+
# land in separate PRs. We set an output rather than failing the step
47+
# so the rest of the job can short-circuit cleanly via `if:` (GitHub
48+
# Actions has no native "skip" exit code).
5949
run: |
6050
if grep -q '^mainnet-smoke\b' Cargo.toml; then
6151
echo "feature_present=true" >> "$GITHUB_OUTPUT"

0 commit comments

Comments
 (0)