thread-safety of vector search

[romange]

Based on my reading of code reading - it seems that hnswlib is used as is, and is not protected by mutexes when calling knnSearch. However, hnswlib knnSearch is not thread safe if concurrent mutations occur. Does it mean that valkey vector search is currently not safe when using with concurrent mutations?

[romange]

nm, found

auto &time_sliced_mutex = parameters.index_schema->GetTimeSlicedMutex();
vmsdk::ReaderMutexLock lock(&time_sliced_mutex);

[yairgott]

Correct, we use the timeslice mutex technique to ensure mutual exclusion between read and write operations, which results in almost completely lock-free read path.

[yairgott]

Closing this discussion.