You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add support for MONITOR command for the RESP3 push type, so, instead of
+1733939274.692107 [0 127.0.0.1:51014] "get" "a"
the connection after sending hello 3 and monitor will receive
>2
$7
monitor
+1733939225.708882 [0 127.0.0.1:51014] "get" "a"
Description of the feature
Original issue is from here antirez/RESP3#21 - first support for redis was opened here redis/redis#11216 .
Now I am reopening it here :) I am not sure this implementation is correct (I am not C expert), in case of any comments I am happy to apply suggested changes.
@KowalczykBartek From the discussion in the PR, it seems that this is a breaking change that csn break someexistng clients or tools.
Do you think an extra parameter to enable Push bahviour can be acceptable? Such as MONITOR PUSH.
This issue describes a change but it doesn't really explain what problem and use cases this change solves. I can see two problems:
When resp3 is used, a client should be able trust that every command gets exacly one regular reply (non-push reply), but monitor sends multiple replies. (This is broken by monitor, but also by the subscribe and unsubscribe commands.)
The client wants to use monitor and send other commands on the same connection.
An optional argument to monitor, like MONITOR [PUSH] can solve 2 but not 1. For 1 we need the guarantee that all commands follow the request-reponse model.
The problem/use-case that the feature addresses
Add support for MONITOR command for the RESP3 push type, so, instead of
the connection after sending hello 3 and monitor will receive
Description of the feature
Original issue is from here antirez/RESP3#21 - first support for redis was opened here redis/redis#11216 .
Now I am reopening it here :) I am not sure this implementation is correct (I am not C expert), in case of any comments I am happy to apply suggested changes.
PR with port: https://github.com/valkey-io/valkey/pull/1426/files
The text was updated successfully, but these errors were encountered: