Last set values not persisted across popup opens for the "all media" controls

[e33et]

Hello valpackett,

Hope you are doing well

I think I'm came across of a unknown bug, cause if you are on Firefox v121.0.1 and go and set a value on SoundFixer and then go to full-screen video it revert to value 1 when you go back while continue watching. Which is kinda annoying, otherwise it works pretty well!

Regards
/e33et

[eylau-ucsd]

Yes, getting this same problem.

[valpackett]

Very strange. You mean like actual gain that's applied, or just the value displayed in the UI? (The "all media on the page" one is just not saved anywhere, which yeah it probably should be… The individual video element one is saved and restored fine.)

[e33et]

Very strange. You mean like actual gain that's applied, or just the value displayed in the UI? (The "all media on the page" one is just not saved anywhere, which yeah it probably should be… The individual video element one is saved and restored fine.)

It's like, when you set a value e.g 1.5 and go in full-screen mode and then press ESC button or the if it called Picture-In-Picture mode button while watching and browsing on a news site. It sets back to value 1 by itself while continue watching same video-clip. Hope I explained it correctly!

[sheravi]

I'm seeing this as well on Firefox 121.0.1. If I click the add-on, boost the volume to something (e.g. 2), then click away from the add-on to watch the video the sound will be boosted to the desired level, but if I click on the add-on again it shows 1.

[valpackett]

Right, so you are just referring to the "all media on the page" part not showing the last adjustment. It does currently show the last applied values on the particular video's settings:

[e33et]

okey it seems that it wasn't a bug after all! It behaves like it should, didn't realize that it was per media element, so the correct value remained standing!

Srry for inconvenience!

[sheravi]

Thanks for explaining that. I had no idea that was how it worked. Sorry about the confusion.