Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appointment-Board #17

Open
vanelnw opened this issue Mar 30, 2023 · 3 comments
Open

Appointment-Board #17

vanelnw opened this issue Mar 30, 2023 · 3 comments

Comments

@vanelnw
Copy link
Owner

vanelnw commented Mar 30, 2023

Our team members are :

  • Vanel nwaba
  • Khomotso Nkansi
  • Abeera Tahir
  • Zia123456
  • Sunday Anthony Ezema

Kandband link

Capture d’écran 2023-03-30 à 21 18 57

@mcrd25
Copy link

mcrd25 commented Mar 30, 2023

Hi Team,

While you made a great effort in this project, unfortunately, I cannot proceed to review your board.

Invalid Code Review Request

You have submitted a project, that does not contain a screenshot of the current state of the Kanban Board at the time of review request which is seen as a requirement here

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.

@mcrd25
Copy link

mcrd25 commented Mar 30, 2023

Hi Team,

Great work so far👏
However there are some issues preventing me from giving the 👍

Highlights

  • screenshot is good now 👍
  • You have descriptions

Optional suggestions

  • the difference in weight for total assigned tasks for any team member should not be greater than 5 so some should not have 24pt and another 18. They can however have 19 or 20. The difference between person with highest weight and lowest weight, essentially, should not be greater than 5. Difference <= 5
  • [OPTIONAL] consider adding labels to help filter by features and would be functional help when issue tracking.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@mcrd25
Copy link

mcrd25 commented Mar 31, 2023

Hi Team,

In my opinion, you are ready to move on to the next step! ⏭️
Good luck! 🎉

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear.

Cheers and Happy coding!👏👏👏


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants