Skip to content

Commit 6274702

Browse files
committed
GHHooks fix for send-to-docs-channel logic
1 parent 4676372 commit 6274702

File tree

4 files changed

+20
-15
lines changed

4 files changed

+20
-15
lines changed

Lambdas/GHHooks/Constants.swift

-9
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,6 @@ enum Constants {
2424
var id: ChannelSnowflake {
2525
self.rawValue
2626
}
27-
28-
static func reportingChannel(repoID: Int) -> Self {
29-
switch repoID {
30-
case 64560805:
31-
return .documentation
32-
default:
33-
return .issueAndPRs
34-
}
35-
}
3627
}
3728

3829
enum Roles: RoleSnowflake {

Lambdas/GHHooks/EventHandler/Handlers/IssueHandler.swift

+1
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ struct IssueHandler: Sendable {
9696
issue: embedIssue,
9797
repo: embedRepo
9898
),
99+
createdAt: self.issue.created_at,
99100
repoID: self.repo.id,
100101
number: self.issue.number
101102
)

Lambdas/GHHooks/EventHandler/Handlers/PRHandler.swift

+1
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ struct PRHandler {
7979
try TicketReporter(
8080
context: self.context,
8181
embed: await self.createReportEmbed(),
82+
createdAt: self.pr.created_at,
8283
repoID: self.repo.id,
8384
number: self.event.number.requireValue()
8485
)

Lambdas/GHHooks/EventHandler/Handlers/TicketReporter.swift

+18-6
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,11 @@ import struct Foundation.Date
55
struct TicketReporter {
66
let context: HandlerContext
77
let embed: Embed
8+
let createdAt: Date
89
let repoID: Int
910
let number: Int
1011
var channel: Constants.Channels {
11-
/// The change to use `.reportingChannel(repoID:)` was made only after this timestamp.
12-
if Date().timeIntervalSince1970 < 1_696_067_000 {
13-
return .issueAndPRs
14-
} else {
15-
return .reportingChannel(repoID: repoID)
16-
}
12+
.reportingChannel(repoID: repoID, createdAt: createdAt)
1713
}
1814

1915
func reportCreation() async throws {
@@ -95,3 +91,19 @@ struct TicketReporter {
9591
try response.guardSuccess()
9692
}
9793
}
94+
95+
private extension Constants.Channels {
96+
static func reportingChannel(repoID: Int, createdAt: Date) -> Self {
97+
/// The change to use `.documentation` was made only after this timestamp.
98+
if createdAt.timeIntervalSince1970 < 1_696_067_000 {
99+
return .issueAndPRs
100+
} else {
101+
switch repoID {
102+
case 64560805:
103+
return .documentation
104+
default:
105+
return .issueAndPRs
106+
}
107+
}
108+
}
109+
}

0 commit comments

Comments
 (0)