Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "these changes are now available in..." message appear to come from merged user when possible #73

Open
gwynne opened this issue Jul 23, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@gwynne
Copy link
Member

gwynne commented Jul 23, 2023

When the "release bot" functionality of Penny is triggered by an appropriately labeled PR, one of the actions it takes is to comment on the PR with "These changes are now available in [](link to new release)." This comment presently comes from the bot itself, and looks like this:

Screenshot_2023-07-23_at_04 07 14

However, if the user who merged the PR (almost always a code owner) has linked their GitHub account to Penny via the OAuth flow, Penny has the ability to act "on behalf of" that user. In that case, Penny should use that ability to comment "as" the merging user (see the docs for auth-ing as a user for an example of what this would look like).

@gwynne gwynne added the enhancement New feature or request label Jul 23, 2023
@gwynne
Copy link
Member Author

gwynne commented Jul 23, 2023

Oh, and doing this would also avoid Penny always being listed as a contributor on PRs in GitHub's social previews when all ti did was add one comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants