Skip to content

Commit 08226c5

Browse files
authored
Fix new NIO warnings (#300)
1 parent 4b8ec14 commit 08226c5

File tree

7 files changed

+14
-28
lines changed

7 files changed

+14
-28
lines changed

Package.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ let package = Package(
1313
.library(name: "PostgresNIO", targets: ["PostgresNIO"]),
1414
],
1515
dependencies: [
16-
.package(url: "https://github.com/apple/swift-nio.git", from: "2.35.0"),
16+
.package(url: "https://github.com/apple/swift-atomics.git", from: "1.0.2"),
17+
.package(url: "https://github.com/apple/swift-nio.git", from: "2.41.1"),
1718
.package(url: "https://github.com/apple/swift-nio-transport-services.git", from: "1.11.4"),
1819
.package(url: "https://github.com/apple/swift-nio-ssl.git", from: "2.14.1"),
1920
.package(url: "https://github.com/apple/swift-crypto.git", "1.0.0" ..< "3.0.0"),
@@ -22,6 +23,7 @@ let package = Package(
2223
],
2324
targets: [
2425
.target(name: "PostgresNIO", dependencies: [
26+
.product(name: "Atomics", package: "swift-atomics"),
2527
.product(name: "Crypto", package: "swift-crypto"),
2628
.product(name: "Logging", package: "swift-log"),
2729
.product(name: "Metrics", package: "swift-metrics"),

Sources/PostgresNIO/Connection/PostgresConnection.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import Atomics
12
import NIOCore
2-
import NIOConcurrencyHelpers
33
#if canImport(Network)
44
import NIOTransportServices
55
#endif
@@ -379,7 +379,7 @@ public final class PostgresConnection {
379379
// MARK: Connect
380380

381381
extension PostgresConnection {
382-
static let idGenerator = NIOAtomic.makeAtomic(value: 0)
382+
static let idGenerator = ManagedAtomic(0)
383383

384384
@available(*, deprecated,
385385
message: "Use the new connect method that allows you to connect and authenticate in a single step",
@@ -412,7 +412,7 @@ extension PostgresConnection {
412412
)
413413

414414
return PostgresConnection.connect(
415-
connectionID: idGenerator.add(1),
415+
connectionID: self.idGenerator.wrappingIncrementThenLoad(ordering: .relaxed),
416416
configuration: configuration,
417417
logger: logger,
418418
on: eventLoop

Sources/PostgresNIO/Data/PostgresData.swift

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
1-
#if swift(>=5.6)
2-
@preconcurrency import NIOCore
3-
#else
41
import NIOCore
5-
#endif
6-
import Foundation
2+
import struct Foundation.UUID
73

84
public struct PostgresData: CustomStringConvertible, CustomDebugStringConvertible {
95
public static var null: PostgresData {

Sources/PostgresNIO/Data/PostgresRow.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
#if swift(>=5.6)
2-
@preconcurrency import NIOCore
3-
#else
41
import NIOCore
5-
#endif
62
import class Foundation.JSONDecoder
73

84
/// `PostgresRow` represents a single table row that is received from the server for a query or a prepared statement.

Sources/PostgresNIO/New/Messages/DataRow.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
#if swift(>=5.6)
2-
@preconcurrency import NIOCore
3-
#else
41
import NIOCore
5-
#endif
62

73
/// A backend data row message.
84
///

Sources/PostgresNIO/New/PostgresCell.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
#if swift(>=5.6)
2-
@preconcurrency import NIOCore
3-
#else
41
import NIOCore
5-
#endif
62

73
public struct PostgresCell: Equatable {
84
public var bytes: ByteBuffer?

Tests/PostgresNIOTests/New/PostgresRowSequenceTests.swift

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import Atomics
12
import NIOEmbedded
2-
import NIOConcurrencyHelpers
33
import Dispatch
44
import XCTest
55
@testable import PostgresNIO
@@ -445,22 +445,22 @@ final class PostgresRowSequenceTests: XCTestCase {
445445

446446
final class MockRowDataSource: PSQLRowsDataSource {
447447
var requestCount: Int {
448-
self._requestCount.load()
448+
self._requestCount.load(ordering: .relaxed)
449449
}
450450

451451
var cancelCount: Int {
452-
self._cancelCount.load()
452+
self._cancelCount.load(ordering: .relaxed)
453453
}
454454

455-
private let _requestCount = NIOAtomic.makeAtomic(value: 0)
456-
private let _cancelCount = NIOAtomic.makeAtomic(value: 0)
455+
private let _requestCount = ManagedAtomic(0)
456+
private let _cancelCount = ManagedAtomic(0)
457457

458458
func request(for stream: PSQLRowStream) {
459-
self._requestCount.add(1)
459+
self._requestCount.wrappingIncrement(ordering: .relaxed)
460460
}
461461

462462
func cancel(for stream: PSQLRowStream) {
463-
self._cancelCount.add(1)
463+
self._cancelCount.wrappingIncrement(ordering: .relaxed)
464464
}
465465
}
466466
#endif

0 commit comments

Comments
 (0)