Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delay property #18

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Add delay property #18

merged 3 commits into from
Jun 13, 2019

Conversation

jdmcd
Copy link
Member

@jdmcd jdmcd commented Jun 13, 2019 •
edited
Loading

Fixes #17

@jdmcd jdmcd requested a review from tanner0101 June 13, 2019 04:03
tanner0101
tanner0101 reviewed Jun 13, 2019
View reviewed changes
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might make sense to name the parameter delayUntil, but besides that, LGTM 👍

@tanner0101 tanner0101 added the enhancement New feature or request label Jun 13, 2019
@jdmcd
Copy link
Member Author

jdmcd commented Jun 13, 2019

Agreed, thanks!

@jdmcd jdmcd merged commit 4f42614 into master Jun 13, 2019
@penny-coin
Copy link

Hey @mcdappdev, you just merged a pull request, have a coin!

You now have 309 coins.

@jdmcd jdmcd deleted the delay branch June 13, 2019 15:30
@tanner0101 tanner0101 mentioned this pull request Jun 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanner0101 tanner0101 tanner0101 left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support re-queueing stuck jobs
3 participants
@jdmcd @penny-coin @tanner0101